Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CanonicallyOrderedAddCancelCommMonoid #9307

Closed
wants to merge 4 commits into from
Closed

feat: CanonicallyOrderedAddCancelCommMonoid #9307

wants to merge 4 commits into from

Conversation

madvorak
Copy link
Collaborator

@madvorak madvorak commented Dec 27, 2023

@j-loreaux
Copy link
Collaborator

@madvorak can you please do at least one of the following?

  1. link to a Zulip thread discussing these changes
  2. provide an explain of the benefits gained on the types ℝ≥0, or ℚ≥0 by having this class (as opposed to having the pieces of it separately, which we already have)
  3. other examples of types satisfying this class, and what is gained by having it (e.g., what new useful theorems can you prove that you can't with existing classes?)

@j-loreaux j-loreaux added awaiting-author A reviewer has asked the author a question or requested changes t-algebra Algebra (groups, rings, fields, etc) t-order Order theory and removed awaiting-review labels Jan 18, 2024
@madvorak
Copy link
Collaborator Author

@madvorak can you please do at least one of the following?

  1. link to a Zulip thread discussing these changes
  2. provide an explain of the benefits gained on the types ℝ≥0, or ℚ≥0 by having this class (as opposed to having the pieces of it separately, which we already have)
  3. other examples of types satisfying this class, and what is gained by having it (e.g., what new useful theorems can you prove that you can't with existing classes?)

I added the link to the Zulip thread, even tho there isn't much.

Other examples are tuples:

instance : CanonicallyOrderedAddCancelCommMonoid (NNReal × NNRat × Nat) := inferInstance

Is like CanonicallyOrderedAddCancelCommMonoid as it essentially is only two symbols but a lot of structure (one of the strongest classes without LinearOrder that you can have).

@madvorak madvorak added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 19, 2024
@j-loreaux
Copy link
Collaborator

@madvorak thanks, but the thread you link to doesn't provide any context about why you want this class.

Is there some theorem you want to generalize or what? Adding useful type classes is fine, but adding them just for the sake of filling out all possible nodes of the hierarchy is something we want to avoid.

I'm not accusing you of the latter, I would just like documented somewhere the reason we have this class.

@j-loreaux j-loreaux added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Jan 19, 2024
@madvorak madvorak removed the awaiting-author A reviewer has asked the author a question or requested changes label Jan 19, 2024
@YaelDillies
Copy link
Collaborator

Sorry, I do not have time to review this before two months at least.

@YaelDillies YaelDillies removed their request for review January 19, 2024 19:45
@j-loreaux j-loreaux added the awaiting-author A reviewer has asked the author a question or requested changes label Jan 19, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 1, 2024
@madvorak madvorak closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-algebra Algebra (groups, rings, fields, etc) t-order Order theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants